fix: correct ylabel rotation regression in bitmap rendering #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementations The rotate_bitmap_90_ccw and rotate_bitmap_90_cw functions had their implementations backwards, causing ylabels to rotate incorrectly. This fix swaps the transformation logic so that: - CCW rotation properly rotates counter-clockwise (for ylabel) - CW rotation properly rotates clockwise Added comprehensive tests to verify rotation logic and ylabel rendering. Fixes #380
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
krystophny
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #380 where ylabels were not rotating 90 degrees counter-clockwise as expected.
Root Cause
The
rotate_bitmap_90_ccwandrotate_bitmap_90_cwfunctions infortplot_bitmap.f90had their implementations backwards. When the ylabel rendering code calledrotate_bitmap_90_ccwto rotate text 90 degrees counter-clockwise, it was actually getting a clockwise rotation.Solution
Swapped the transformation logic in both rotation functions so that:
rotate_bitmap_90_ccw: Now correctly rotates counter-clockwise using transform (i,j) → (j, width-i+1)rotate_bitmap_90_cw: Now correctly rotates clockwise using transform (i,j) → (height-j+1, i)Testing
Added comprehensive tests:
test_rotation_debug.f90: Visual debugging of rotation transformationstest_ylabel_rotation_fix.f90: Basic ylabel rendering testtest_ylabel_rotation_regression.f90: Comprehensive test with rotation logic verificationAll existing ylabel tests pass after the fix.
Fixes #380